Change input locks to fix map spin, Fixes #2126 #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also added some input locking to all kOS windows including the GUI, to help get rid of some of the click-through problems some of them had.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added some input locking to all kOS windows
including the GUI, to help get rid of some of the
click-through problems some of them had.
It is unclear WHY the stock game has this weird behavior in regards to the TARGETING input lock flag, but it does, so this ad-hoc ugly fix was my way around it - I go ahead and lock everything in the terminal including TARGETING (this gets rid of the spinning bug but introduces a new bug that you cannot SET TARGET from inside a script while the terminal window is focused). Then I get around that new bug by using a different technique to allow TARGETING than we used before - I simply temporarily turn off the terminal input lock the line before setting the target, then restore the terminal input lock immediately afterward on the next line.