added constant:g0, and edited the doc more about G vs G0. #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis build failed because it's using KSP 1.4.1 and it turns out PhysicsGlobals.GravitationalAcceleration was only just recently added for KSP 1.6 and up - I didn't know that. (I suspect SQUAD only started caring about ensuring they were using a standard constant g0 across all their code when they wanted to do dV calculations in KSP 1.6 and those calculations need that g0 because of that weird way ISP measures fuel by Newtons instead of by mass.) To support backports, I'm going to have to change this implementation into something involving reflection where it tests to see if PhysicsGlobals has a GravitationalAcceleration member first, and if it does not then it falls back to a hardcoded literal instead. |
Dunbaratu
added
the
Not Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2413.
g0 is simpler than G was - g0 actually is in the physics globals.