Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connectivity manager appearance #2493

Merged

Conversation

madman2003
Copy link
Contributor

I tried to explain how the dialog position was chosen, because this is really non-trivial.

Fixes the connectivity manager appearing off-screen for me.

@Dunbaratu
Copy link
Member

Testing this it all looks good. I even fiddled with 200% UI scale on minimum resolution (it looks quite bad that way, but it does put the dialog box in the right place.)

Those dialog box parameters make no sense without being documented. Thanks for doing all the trial and error to reverse-engineer it and provide the "missing documentation".

@Dunbaratu Dunbaratu merged commit 97d1bd0 into KSP-KOS:develop Apr 28, 2019
@Dunbaratu Dunbaratu added the bug Weird outcome is probably not what the mod programmer expected. label May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Weird outcome is probably not what the mod programmer expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants