Lexicon suffixes (Fixes #2551) #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making this work required a few things: 1 - overriding GetSuffix and SetSuffix so that if a Lexicon fails to Get or Set suffix on the normal suffixes, it falls back to trying it on the keys. 2 - Making it so that GetSuffix and SetSuffix are sometimes allowed to fail without throwing an exception, since expecting them to sometimes fail is now part of Lexicon's normal execution path it doesn't seem right to "communicate" that fact to Lexicon with an exception it has to catch. 3 - Also overriding HASSUFFIX and SUFFIXNAMES so they reflect the fact that some lex keys effectively become "suffixes" now.
The test for if a string is a valid identifier was allowing partial matches to count, so for example the string: "StartsLikeIdentifierButHas *garbage*!(# afterward" was getting called a valid identifier by the Lexicon suffix system.
Dunbaratu
added
the
Pending Documentation
|
I Just noticed that this PR is missing Sphinx doc changes to describe the new feature. It should not be merged without that. |
Dunbaratu
changed the title
Dunbaratu
changed the title
Dunbaratu
removed
the
Pending Documentation
Dunbaratu
changed the title
Dunbaratu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2551 Fixes #2288
Making this work required a few things:
1 - Overriding GetSuffix and SetSuffix so that if a Lexicon
fails to Get or Set suffix on the normal suffixes, it falls
back to trying it on the keys.
2 - Making it so that GetSuffix and SetSuffix are sometimes
allowed to fail without throwing an exception, since expecting
them to sometimes fail is now part of Lexicon's normal execution
path it doesn't seem right to "communicate" that fact to
Lexicon with an exception it has to catch.
3 - Also overriding HASSUFFIX and SUFFIXNAMES so they reflect
the fact that some lex keys effectively become "suffixes" now.