Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ETA:APOASIS return 0 on on hyperbolic trajectories #2646

Merged
merged 2 commits into from
Jan 12, 2020
Merged

Make ETA:APOASIS return 0 on on hyperbolic trajectories #2646

merged 2 commits into from
Jan 12, 2020

Conversation

ThunderousEcho
Copy link
Contributor

Resolves #2229

@Dunbaratu
Copy link
Member

For personal issues I have been away from kOS for a while. I'm coming back into it again and looking at these PRs.

It seems to me that a better solution might be a really big number rather than zero. Not infinity, but something like Single.MaxValue (and the documentation changed to match). I was thinking Double.MaxValue, but because I don't want the chore of proving the code never passes the value through a single float at any point, I think Single.MaxValue would be safer (and still larger than any "real" value an elliptical orbit in the game would return).

@Dunbaratu Dunbaratu merged commit 00fa352 into KSP-KOS:develop Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETA:Apoapsis crashes the kOS script if on an escape trajectory
2 participants