Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2669: additional asteroid functionality #2736

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Fix #2669: additional asteroid functionality #2736

merged 1 commit into from
Sep 6, 2020

Conversation

JonnyOThan
Copy link
Contributor

add STOPTRACKING and SIZECLASS suffixes to Vessel

add STOPTRACKING and SIZECLASS suffixes to Vessel
@Dunbaratu
Copy link
Member

I see you did a few PR's recently. Thank you.

I was about to merge this one but I want to ask a few clarifications because I'm trying to write user-facing documentation for it and want to say the right things:

1 - Not all Vessel objects are asteroids. They might just be a normal ship. What is the expected result if a user attempts to call :STOPTRACKING on a Vessel that isn't actually an asteroid? Or on a vessel that is an asteroid, but hasn't had tracking started in the first place? Will it throw an exception or will it fail silently? (As a general rule, if it does throw an exception I prefer to detect the problem case ourselves and throw our own homemade exception rather than letting some built-in .Net exception "bleed" through to where the user sees it in the terminal and gets confused by what it means.)

2 - Same question, but for :SIZECLASS - what is the SIZECLASS of a non-asteroid vessel going to say?

3 - I haven't yet played with the new comets in KSP 1.10.x. Do you know if comets are basically just asteroids in the KSP API? (Meaning should the documentation say these suffixes are for "Asteroids" or should it say "Asteroids and Comets").

@Dunbaratu
Copy link
Member

Well, I'm going to merge what I have, even if it's lacking some explanation in the docs, because I want to move on.

@Dunbaratu Dunbaratu merged commit dfbe532 into KSP-KOS:develop Sep 6, 2020
@JonnyOThan JonnyOThan deleted the asteroids branch December 15, 2020 04:18
Dunbaratu added a commit to Dunbaratu/KOS-1 that referenced this pull request Jan 17, 2021
(I noticed when writing this up that the asteroid PR
in KSP-KOS#2736 has no documentaion and needs it.  I am committing
what I have so far so I can come back to this branch
later after I add those docs.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants