Force all input through buffer unless flushing buffer. #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes KSP-KOS#2753 (I hope - I can't test it.) Now the only input that is allowed to immediately get sent to the interpreter is that which came FROM the buffer flusher routine ProcessUnconsmedInput(). It uses flags that allow its input to come through directly, but *everything else* that types input is now requried to queue it (so it will pass through ProcessUnconsumedInput() a moment later). Hypothetically this should fix the ability for input to skip the buffer and jump in line. The one exception is the immediate characters related to terminal closing or program interruption like CTRL-C. They are allowed to jump in out of order. And in the case of CTRL-C, it also flushes whatever was in the buffer so if you typed anything ahead it will no longer get executed after a CTRL-C like it used to.
Dunbaratu
added
the
bug
|
I just discovered a bug this PR has - the telnet terminal is frozen when the in-game GUI terminal is not open. (If it's not open, the buffer flush never happens and the keypresses that are getting queued up never get used until you open the terminal and then it all comes flooding in.) |
|
I think the recent change fixes the problem I found - and it looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2753 (I hope - I can't test it because I couldn't cause the bug in the first place - I need @JonnyOThan to test it for me.)
Now the only input that is allowed to immediately get
sent to the interpreter is that which came FROM the
buffer flusher routine ProcessUnconsmedInput(). It
uses flags that allow its input to come through
directly, but everything else that types input is
now required to queue it (so it will pass through
ProcessUnconsumedInput() a moment later). Hypothetically
this should fix the ability for input to skip the buffer
and jump in line.
The one exception is the immediate characters related
to terminal closing or program interruption like CTRL-C.
They are allowed to jump in out of order and happen immediately.
And in the case of CTRL-C, it also flushes whatever was in the
buffer so if you typed anything ahead it will no longer
get executed after a CTRL-C like it used to.