Fixes #2782 by moving msg hooks around. #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The best fix I could think of was to maintain a list of which vessels' autopilots wanted to have the message on versus which do not. That avoids the problem of one vessel turning off the flag when another vessel wanted it on. Now there's a HashSet of all the vessels that want the flag on. As long as there's at least one vessel that wants it on, it stays on. Only when all vessels want it off does it turn off. Also, the vessels can turn it off in their remove hooks code that happens when their autopilots get destructed, thus avoiding the scene change bug that the issue talked about.
Dunbaratu
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2782
The best fix I could think of was to maintain a list of which
vessels' autopilots wanted to have the message on versus which
do not. That avoids the problem of one vessel turning off the
flag when another vessel wanted it on. Now there's a
HashSet of all the vessels that want the flag on. As long as
there's at least one vessel that wants it on, it stays on. Only
when all vessels want it off does it turn off. Also,
the vessels can turn it off in their remove hooks code that
happens when their autopilots get destructed, thus avoiding the
scene change bug that the issue talked about.