PIDLoop Serializable and Minoutput in ToString. #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes KSP-KOS#2743 by making PIDLoop a proper SerializableStructure, which it wasn't before. Also added MinValue to the ToString, which wasn't there before, and added it to the CSV dump, which may change things for people using that feature (minor breaking?)
Dunbaratu
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2743 by making PIDLoop a proper SerializableStructure,
which it wasn't before.
Also added MinValue to the ToString, which wasn't there before,
and added it to the CSV dump, which may change things for
people using that feature (minor breaking?)
Note, the BREAKING tag is just in case anyone was using the CSV output feature of PIDLoop. I noticed it failed to mention MinOutput before,
which I inserted just before MaxOutput, shifting it over 1 column.