Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http to https links and fix broken ones #2967

Merged
merged 8 commits into from
Jul 13, 2021

Conversation

kna27
Copy link
Contributor

@kna27 kna27 commented Jun 14, 2021

Fixes #2966

Update links in the kOS error messages in the terminal from HTTP to HTTPS. Additionally fixes broken links that point to nowhere and give a 404 error.

@kna27 kna27 changed the title [Not Ready] Rename http to https links and fix broken ones Rename http to https links and fix broken ones Jun 14, 2021
@kna27
Copy link
Contributor Author

kna27 commented Jun 14, 2021

This is now ready to be merged, however, I am not sure about one of the broken links.
I replaced https://ksp-kos.github.io/KOS_DOC/summary_topics/coordframe/raw/ with https://ksp-kos.github.io/KOS_DOC/math/geocoordinates.html. If someone could confirm if this is right or tell me what to change it to, it would be appreciated. Other than that, ready to merge!

@nuggreat
Copy link

nuggreat commented Jun 14, 2021

depending on the context of https://ksp-kos.github.io/KOS_DOC/summary_topics/coordframe/raw/ it could also be intended to point at https://ksp-kos.github.io/KOS_DOC/math/ref_frame.html#origin-position

EDIT: looking at the surrounding text in your changes it definitely should be referencing the https://ksp-kos.github.io/KOS_DOC/math/ref_frame.html#origin-position not geocoordinates as everything in there has to do with vectors and one of the critical things when it comes to working with vectors is knowing the origin of the vector.

EDIT2: the velocity related suffixes might also be better served by linking to: https://ksp-kos.github.io/KOS_DOC/structures/orbits/orbitablevelocity.html as they do not directly return vectors.

@kna27
Copy link
Contributor Author

kna27 commented Jun 14, 2021

Fixed, thank you!

@Dunbaratu Dunbaratu merged commit 4c5acd7 into KSP-KOS:develop Jul 13, 2021
@kna27 kna27 deleted the rename_links branch July 14, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http link in terminal should be https
3 participants