-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In 1.12.2 version, after applying this mod , the structures of spacecrafts are very stable, but the docking ports are still as soft as rubber. #9
Comments
Well yes. KJR doesn't reinforce joints on robotic parts which technically docking ports also are since 1.12. |
Ok, thanks! This mod worked perfectly when I was playing 1.11 and I enjoyed a lot. Maybe I need to activate my brain storm to overcome this "noodle effect". |
Fixed in d59438f |
I'm not familiar with writing mods but is it possible to override this behaviour and make docking ports fire the event? I'm assuming they're supposed to fire the event when toggling the rotation lock, or maybe I'm misunderstanding. I tried building a ship that relies on rotating docking ports and realized this update breaks rotation completely (the ports try to rotate and then eventually explode or snap back to their original position). Toggling reinforcement off in the difficulty settings window and then reloading the ship let me rotate the ports again of course but it's a bit of a hassle going back and forth every time. I downgraded to the previous version for now, not sure what to do. |
- Now also prevent coordinate drift of the moving part of the servo parts. - Simplified rotation offset computation by directy using euler angles instead of doing an angle axis conversion. This is faster abd align the method used with what stock is using to compute the offset angle, and stress testing show no drift degradation or improvement using that solution. - New mod API patch : DockingPortLockedEvents (added for KJR, see [related issue](KSP-RO/Kerbal-Joint-Reinforcement-Continued#9)) - PAWCollapsedInventories : Fixed mass/volume info not updating correctly in the group title. - New bugfix : DockingPortLocking, fix some user-facing inconsistencies with the docking port rotation locking feature and hide irrelevant PAW items when the docking port is locked.
Note that the stock docking port rotation feature suffer from the same issue as robotic parts : it cause all children parts of docking ports to have their pristine positions lost and set to whatever in-physics deformation is currently happening. Over the course of multiple save/load or scene switch cycles, this will cause the vessel to become more and more permanently deformed. @siimav Added the robotics event firing on docking port lock state change, will be available in next release. |
Release v3.6.1 now makes use of the KSPCommunityFixes patch. Thanks, @gotmachine! |
No description provided.
The text was updated successfully, but these errors were encountered: