Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Modular RCS Restock models scale #236

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

ezsnackeur
Copy link
Contributor

Changes the scale on the Restock models to be in line with all the other models. Mini ones are still a little bit smaller at 2/3 the nozzle diameter compared to the rest.

Changes the scale on the Restock models to be in line with all the other models. Mini ones are still a little bit smaller at 2/3 the nozzle diameter compared to the rest.
@siimav
Copy link
Collaborator

siimav commented Aug 5, 2024

The regular-type Restock variants look all good.
1- and 5-way Restock mini looks good; 2-, 3- and 4-way mini models are still a bit too small IMO.

@ezsnackeur
Copy link
Contributor Author

All the mini variants share the same nozzle diameter as they did before. i dont know what you are referring to :<
image

@siimav
Copy link
Collaborator

siimav commented Aug 5, 2024

Ugh, the Restock mini parts are weird in that they're the same height as regular ones but nozzle diameter and the rest of the dimensions are way smaller.
image

@ezsnackeur
Copy link
Contributor Author

ezsnackeur commented Aug 5, 2024

i think the base of the mini ones is just supposed to be offset into the tank its placed on tbf.
image
like this for reference.

they would look very weird if 1 axis is scaled differently to the others.
maybe i should make the mini ones 1/2 scale instead of 2/3? they would still be bigger than what they were originally

@Capkirk123
Copy link
Member

I don't think that's what's being suggested.

Just scale based on the nozzle (it's more realistic, and it'll make the engine plume fit more consistently). It's fine if one part ends up a little bulkier than another in the end.

@ezsnackeur
Copy link
Contributor Author

ezsnackeur commented Aug 11, 2024

Thats exactly what i did. all the restock models match all the other models nozzle diameter while mini ones are 2/3 nozzle diameter.

@ezsnackeur
Copy link
Contributor Author

So should i change anything or? In my opinion this is fine as is

@siimav
Copy link
Collaborator

siimav commented Aug 29, 2024

I'm personally not happy with the fact that the mini variant produces the same thrust at significantly smaller throat and nozzle sizes. I guess it's still an improvement over the previous state though.

@ezsnackeur
Copy link
Contributor Author

ezsnackeur commented Aug 29, 2024

If you make them same nozzle diameter the mini ones come out as a bigger model overall (as you pointed out the model is already very tall) that wouldn't make sense imo.

@Capkirk123
Copy link
Member

Eh whatever. IMO it doesn't matter if the mini models end up "bigger", but if it really bothered me I would have changed it already.

@Capkirk123 Capkirk123 merged commit cc57b93 into KSP-RO:master Oct 19, 2024
3 checks passed
@ezsnackeur ezsnackeur deleted the patch-1 branch October 26, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants