Earth Observation/Commercial Applications Programs

[SierraHotel84]

Added commercial applications program with contracts, disabled EOS2/CA2

Cherenkov Detector created, placed, and configured

-Created placeholder EOS2, Commercial Apps, Commercial Apps Advanced programs
-Moved all com/nav sat contracts out of Targeted Sats
-Renamed Targeted Sats to EOS1
Included Corona and Orbital Perturbation for now, can update these later
-Working on adding Commercial Apps 1
Need to test a couple of minor changes in the optional contracts
Have given rep values only a cursory look so far, need to go over those a little closer
Sort keys are all over the place Removed

Github bugged out

[ppboyle]

Took a quick look at this branch.

Currently Corona and Molyniya contracts are not working due to CC issues - I imagine that's know? Do you need assistance?

I'm still concerned about how easy it is to complete EOS with 3 launches - 1 launch for corona, one for IR and then a small kick to do gravimetric - so 7 days + 60 days - and 1 launch that can simultaneously do Magnetometer + Cosmic Ray + Cherenkov, without even doing a kick - in fact the requirements on those 3 are so similar players would almost be stupid not to do them simultaneously.

The gravimetric contract's inclination requirement is odd - it's requiring 48 to 52 degrees inclination, while the experiment itself requires 50 to 130. So actually the player can only complete the contract at 50 to 52? I think the contract should match the experiment.

The Cosmic Ray Beyond LEO contract says it requires a TV camera in text, but doesn't actually.

Having Early Comms or Early Nav contracts active at the same time as the constellation contracts may cause problems - eg: A satellite for one can be counted by the other. You may wish to resolve this by either locking out the corresponding contracts, or making the requirements mutually exclusive.

[Teykn]

Currently Corona and Molyniya contracts are not working due to CC issues - I imagine that's know? Do you need assistance?

@SierraHotel84
Suspect that in Corona, you need to use @/maxCompletions instead of @maxCompletions, and in Molniya, @payload instead of @/payload

[SierraHotel84]

@ppboyle thanks, all good points. The one thing I did just think about is that the Cherenkov unlocks in the next science node after CR1 and Mag1, so it'll take quite a bit more science to complete it, which I think basically forces it into its own launch. Will take a look at that, though. I also wasn't thinking about the fact that all of the contracts could be accepted at once, the New Vessel node had me thinking it would block that but then realized it's how you can combine contracts for first satellite, so I'll tweak that as well. Good catch on the grav one, I was basing the orbital requirement off the historical satellite orbit, but hadn't looked at the experiment req's yet.

@Teykn thanks, looking at the CC errors next

[NathanKell]

@ppboyle thanks, all good points. The one thing I did just think about is that the Cherenkov unlocks in the next science node after CR1 and Mag1, so it'll take quite a bit more science to complete it, which I think basically forces it into its own launch.

Why would it, rather than just pushing the player to wait to launch until it's available, like players often wait to combine FO and FSO? Note that the collect-science parameter doesn't require that vessel to collect the science, so the player could be collecting science with the named experiments prior to that launch and merely "finish off" the science with that launch.

[SierraHotel84]

Hmm, fair point.

[NathanKell]

@SierraHotel84 LMK when everything's tested and working and I'll merge! :)

[SierraHotel84]

Will do, hoping to get it all wrapped up tomorrow

[SierraHotel84]

Where are these values stored? I thought I'd updated all of the configs for the new part but can't seem to find this one.

So far this is proving to be a challenging set of contracts due to the limited science early on. I think for the average player with the new balance changes, this is going to be a much more engaging couple of programs. Will upload all of the tweaks/changes at once later today.

[NathanKell]

Where are these values stored? I thought I'd updated all of the configs for the new part but can't seem to find this one.

So far this is proving to be a challenging set of contracts due to the limited science early on. I think for the average player with the new balance changes, this is going to be a much more engaging couple of programs. Will upload all of the tweaks/changes at once later today.

When you add the part to the parts browser (or once added, by searching for the part and clicking on it), you can change the cost there. Then commit your changes to json, and then generate configs.

[SierraHotel84]

@NathanKell Ok, I think I'm calling it ready to go! Per @ppboyle's comments, I gated Cherenkov and MagScan behind CosmicRay1, which also fits historically since they were a few years later. Also adjusted orbit requirements to make them far less likely to be combined. Added blocks in Com and Nav networks for the repeatables.

[NathanKell]

@SierraHotel84 great!! And you were able to successfully complete all contracts in both programs?

[SierraHotel84]

I didn't do the com network since it is already known to work, or nav network since it's basically a direct port of the com ones. Corona and Corona Rep I had to cheat a little since I didn't have the new photo experiments. I didnt try the new orbital requirements on the ones mentioned above but previously tested them.

[NathanKell]

I'm confused with Corona--that's why I mentioned using RP0photos1 since you would have that experiment. Or did you mean you did do them with the photos1 experiment and they worked?

For CA, while it's true the contracts are broadly a port, it's still worth testing--if nothing else that will verify the contract flow is correct, and that nothing re: rewards or other things got busted in the porting over.

Yeah the orbital-requirement change stuff makes sense.

Great to hear with the others!

[SierraHotel84]

Fair point on the nav network, will run through it tomorrow to verify. CoronaRep would have completed with the updated shortened experiment length, just didn't have enough battery to run full original length. I'll grab photos1a out of BB and do Corona again to be sure.

[NathanKell]

Eh doing it with photo1 is fine! It's not like they're really different. Feel free to use infinite EC or something :)

[SierraHotel84]

Had to ditch the CollectScience from CoronaRep, tried using the original Photo2, the one from BB, and a custom one, and it would not complete the collect step no matter how I rearranged the config. Left it as a part validation for the camera and a time requirement that matches the new photos2 experiment. All other contracts checked out and validated as intended.

[NathanKell]

Thanks for doing that final pass! Looks like you caught a bunch of stuff we both missed. :)

And THANK YOU for making these programs! Merging with pleasure.