Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make targeted moon landing easier #2425

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

uriyuzhui
Copy link
Contributor

@uriyuzhui uriyuzhui commented Aug 17, 2024

Current Crewed Targeted Moon Landing requires landing within 1km of target locations, which is very difficult due to in-game limitations, also also does not make sense that the entire mission becomes a failure if you miss the site by just 1km.

The modified version:

  • Relax distance requirement 1km -> 10km for completion (updated)
  • Bonus science if you land within 3km, which is roughly how far off Apollo did historically
  • Total reputation is unchanged (25% moved from base to the optional part)
  • Check waypoint distance and landing status concurrently to prevent cheesing it by landing and then fly-by the waypoints

Also fixing some texts along the way.

@siimav
Copy link
Contributor

siimav commented Aug 17, 2024

I feel like 25km is too loose of a requirement. Something like 10km should still be easily achievable with a bit of practice and at the same time provide at least some challenge.

@siimav
Copy link
Contributor

siimav commented Aug 17, 2024

On a separate note: all rover contracts need updating too to follow the same pattern as #2418

@uriyuzhui
Copy link
Contributor Author

  • Fix the texts referring to plural "target locations"
  • Lower the threshold 25km -> 10km for completion
  • Move the VisitWayPoint blocks to be in the same ALL block as landing state checking, to seal the loophole of flying-past waypoints before/after landing

@siimav
Copy link
Contributor

siimav commented Aug 18, 2024

There's something funky going on with the indentation now.

@uriyuzhui uriyuzhui requested a review from siimav August 19, 2024 19:03
@uriyuzhui
Copy link
Contributor Author

image

Passed the test with an end-to-end out-of-simulation run.

@siimav siimav merged commit 71b2e9a into KSP-RO:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants