Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stock landing gear lights remain active when stowed #122

Closed
JonnyOThan opened this issue Feb 7, 2023 · 3 comments
Closed

Stock landing gear lights remain active when stowed #122

JonnyOThan opened this issue Feb 7, 2023 · 3 comments
Labels
kspBug Identified KSP issue

Comments

@JonnyOThan
Copy link
Contributor

JonnyOThan commented Feb 7, 2023 •
edited
Loading

When the light action group is on, the white lights on the stock landing gear parts will be active even when the gear is stowed. This is purely cosmetic, but it's a pretty terrible bug (often illuminating the sides of your planes) and much more noticeable when waterfall is installed (see the vertical cones of light in this image):
image
@gotmachine gotmachine added the kspBug Identified KSP issue label Feb 7, 2023
@gotmachine
Copy link
Contributor

gotmachine commented Mar 30, 2023 •
edited
Loading

Landing gear deployment is controlled by ModuleWheelDeployment, the light is controlled by ModuleLight.
ModuleLight implements IScalarModule, which is how the light status based on deployment status is handled.
ModuleWheelDeployment know about ModuleLight through the ModuleWheelDeployment.slaveModules KSPField, which should be set to the indice of the ModuleLight.

Issue is that slaveModules isn't set to the right indice in the stock configs for some parts. It is set to 8 in all parts, but :

  • For the SmallGearBay (LY-10), ModuleStatusLight is at indice index 9 (doesn't works correctly)
  • For the GearSmall (LY-35), ModuleStatusLight is at indice index 9 (doesn't works correctly)
  • For the GearMedium (LY-60), ModuleStatusLight is at indice index 8 (works correctly)
  • For the GearLarge (LY-99), ModuleStatusLight is at indice index 8 (works correctly)

This can be easily fixed with a MM patch.

gotmachine added a commit that referenced this issue Mar 30, 2023
@gotmachine
- New stock configs fix, **[LandingGearLights](#122 : fix the lights …
5d3f197 
…on the "LY-10" and "LY-35" landing gears not automatically turning on/off when extending/retracting the landing gear.

- New KSP bugfix/QoL patch, **LadderToggleableLight** : fix for the stock "Kelus-LV Bay Mobility Enhancer" light being always active even when the ladder is retracted, and implements manual control of the light.
@JonnyOThan
Copy link
Contributor Author

btw the singular of indices is "index" :p

@gotmachine
Copy link
Contributor

Indeed :P

@kretze kretze mentioned this issue May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kspBug Identified KSP issue
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonnyOThan @gotmachine