Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCPCF breaking Infernal Robotics - Next PAW float edit entries #40

Closed
Rodg88 opened this issue May 28, 2022 · 1 comment
Closed

KCPCF breaking Infernal Robotics - Next PAW float edit entries #40

Rodg88 opened this issue May 28, 2022 · 1 comment
Labels
bug Something isn't working mod-compat Compatibity issue with another mod

Comments

@Rodg88
Copy link

Rodg88 commented May 28, 2022

I'm getting log spam while a PAW for any IR robotic part is open, in the editor or flight with KSPCF:

ItemPrefab for control type 'UI_FloatEditEx' not found.

Tested with only IR installed, and the float edit fields show up as normal. Eg Force, Acceleration, Max Speed, and Min and Max limits. Then added in only KSPCF, and the float edit entries stop showing and the errors start.

Log in case it's useful: https://gist.github.com/Rodg88/a689bf8f53f445238d666bbfcb196e2c

@gotmachine gotmachine added bug Something isn't working mod-compat Compatibity issue with another mod labels May 29, 2022
@gotmachine
Copy link
Contributor

So, the issue is that the KSPCF UIFloatEditNumericInput patch replaces the stock prefab with a derived class, and IR uses a strict type check when it tries to copy the stock prefab to build it's own customized version, here and here.

This could be fixed on the IR side by using a non-strict type check, but ideally KSPCF should avoid interfering.
I will see what I can do.

gotmachine added a commit that referenced this issue May 29, 2022
…control. Don't alter the control prefab list, instead return our custom prefab on the fly in the KSP methods searching the prefab list.
gotmachine added a commit that referenced this issue Jan 30, 2023
…control. Don't alter the control prefab list, instead return our custom prefab on the fly in the KSP methods searching the prefab list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mod-compat Compatibity issue with another mod
Development

No branches or pull requests

2 participants