-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Essay submission #1355
Essay submission #1355
Conversation
@KallePettersson, can you give feedback on our essay? |
Hi @MDRezaulHasan, I've now finished the feedback on your essay! Very good job on the report! You can view it either in the PR #1397 or pasted below here: Feedback on essayMembers:Name: Kalle Pettersson (kalpet@kth.se) Feedback on "Comparison of DevOps Pipeline Setup in Public Cloud(Azure, AWS, and GCP)"General impressionOverall a very well written and technical report I think you guys can be proud of. You manage to provide a good overview of how setting up pipelines on the three public Cloud platforms can be done. Your use of images help a lot with this since there are a lot of "buzzwords" that need to be thrown around when writing about these things. The structure of you report is also very clear and reasonable. 1: IntroductionInteresting and well written introduction! I really like how you guys motivated your decision to focus on Azure, AWS, and GCP, not only did you cite the source but summarized the reasons which makes it even more convincing. 2: Comparison of DevOps Pipeline setup2.1...When you use acronyms such as "PaaS" and "IaaS" it would be nice if you could use their full names the first time you introduce them. For instance writing "Platform as a service (PaaS)" when introducing Paas. Maybe having sections explaining what PaaS and IaaS means would be nice to have as well. Since they are frequent terms used throughout your essay it's important that the reader understands them. Sections 2.1.1 to 2.1.3 which describe the different ways of setting up the pipelines on the different Cloud platforms are very good. Showing the images that you do makes it a lot easier to grasp what you are writing. 2.2...I like your table which clearly defines what the different types of VM's are. One improvement you could make here is to separate out the information about which type of VM's each Cloud provider offers into new columns. For instance something like this:
Or maybe separate this information into another paragraph of text. This would make it easier for the reader to see what the different Cloud providers actually provide. An interesting thing to add while you’re on the subject of geographical reach would be to include information about the market share of these providers. Not completely relevant and necessary considering your topic but as a reader it would be interesting to know. This link might be useful. 3: ConclusionThe conclusion is well written and connects well to what you brought up in the previous sections. Your final "In conclusion..." sentence, while being General improvements and notesImage referencingI love your extensive use of images, they work very well in aiding the reader in understanding what you are writing about! I noticed that you don't explicitly reference figure 3 and 4, this is something you could easily fix which would make the text more consistent. You should also consider to create a reference list to all the images you use. Suggested changes to sentencesIntroductionI only really found one sentence that I thought could use some changes, which says a lot about the overall quality of the text.
Nitpicky stuff
|
Thanks, @KallePettersson, We will take care of your suggestion in the final submission. |
Thanks @KallePettersson for such constructive feedback. It will help us in improving our final submission immensely. |
Hi @khaes-kth, It shows some conflict. How could I solve it |
Your PR is changing three files at the same time. |
@khaes-kth I can not find a Resolve option in this conflict. I am not able to remove the commit. I might be deleted my previous repository from my git hub account which repository send this PR. Can you help me solve this issue? |
No description provided.