-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission Covid19: Help Fight Covid19 Social Web App #633
Conversation
Added folder and README.md file.
Hi @sujon2100 , as a very basic rule in this course: every task should be registered via a PR first. Have you registered this task before, and got the proposal merged into the repo? Or do you mean you are submitting a task proposal, instead of a final deliverable? |
My group member has already created the project proposal before. Here is the link: https://github.com/Nick-Steele/devops-course/blob/master/contributions/covid19/nsteele-mhud/README.md. So, I have created #633 this because you have asked me to add comments in the readme file. And finally, I have asked for feedback here:#601. This project is already completed now we need feedback before final submission. |
We already did this quite some some time ago our project was pushed to the covid-19 contributions in our folder. |
@sujon2100 @Nick-Steele , the proposal is located in your forked repo and is not proposed as a PR for a review. In the course repo, folder https://github.com/KTH/devops-course/tree/master/contributions/covid19, you will not find your registered task folder. By rule, only creating a proposal in your own forked repo, without submitting a proposal PR and getting it merged, is not considered as a valid task. Anyway I'm checking the contents now to see if the project is qualified to be merged. Please pay attention to the task registeration rules. I think you have already done several PRs for your other tasks, correct? |
Apologies, that was my mistake. |
@sujon2100 @Nick-Steele I'm fine with the idea. Please correct the folder name in order to get the PR merged: https://github.com/KTH/devops-course/tree/master/contributions/covid19#how-to-register-your-topic |
…tions/covid19/mhud-nsteele/README.md Folder's name is changed according to the rules!
Thank you @gluckzhang . I have changed the folder name, here you can see: https://github.com/KTH/devops-course/pull/633/files |
Now could you register for the feedback? Here is the feedback pull request: #601 |
Thanks for the update. Now the PR is merged. |
Feedback: This is a first milestone. Major points that are missing:
Minor points:
|
Hi @monperrus ,
(Done) link to a public repo with source code (Done) add fat captions to each figure to explain what they show and why they are interesting Thanks! Best regards |
Added folder and README.md file.