-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] 리뷰요청 메일 양식에 리뷰 작성 url 추가 #162
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -239,9 +239,9 @@ | |
<table align="center" border="0" cellpadding="0" cellspacing="0" role="presentation" style="border-collapse:separate;line-height:100%;"> | ||
<tr> | ||
<td align="center" bgcolor="#2F67F6" role="presentation" style="border:none;border-radius:3px;color:#ffffff;cursor:auto;padding:15px 25px;" valign="middle"> | ||
<p style="background:#2F67F6;color:#ffffff;font-family:'Helvetica Neue',Arial,sans-serif;font-size:15px;font-weight:normal;line-height:120%;Margin:0;text-decoration:none;text-transform:none;"> | ||
<a th:href="@{https://kuddy.co.kr/my/write-review/{meetupId}(meetupId = ${meetupId})}" style="background-color: rgba(0, 0, 0, 0); color: #fff; font-family: 'Helvetica Neue', Arial, sans-serif; font-size: 15px; font-weight: normal; line-height: 120%; Margin: 0; text-decoration: none; text-transform: none;"> | ||
Write a Review | ||
</p> | ||
</a> | ||
</td> | ||
</tr> | ||
</table> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 해당 코드 패치를 간단하게 검토해보겠습니다. 이 코드 패치의 변경 사항은 특정 링크를 감싸는 HTML 요소를 향상 사항 및 버그 리스크:
이 외에도 코드 자체 외에 버그나 개선사항을 평가하기 위해서는 목적 및 문맥을 더 이해해야 할 필요가 있습니다. |
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아래는 코드 패치입니다. 이에 대한 간단한 코드 리뷰와 버그 위험 및 개선 제안을 도와드리겠습니다.
리뷰어 메소드에서
sendReviewRequestEmail
은 두 회원 간의 서로에게 이메일을 보내는 역할입니다.sendReviewRequestEmail
메소드 안에서는 이메일이 전송될 관련 멤버, 제목 및 텍스트 콘텐츠가 설정됩니다. 번역된 HTML 템플릿(email-form.html
)에 대한 변수도 설정됩니다.개선 제안:
sendReviewRequestEmail
메소드를private
으로 변경하는 것이 좋습니다. 외부 클래스나 외부 패키지에서 직접적으로 액세스하지 않아도 되기 때문입니다.setContext
메소드와sendReviewRequestEmail
메소드에서meetupId
변수를 받고 사용하므로,setContext
메소드의 인자에도meetupId
를 추가해야 합니다.sendReviewRequestEmail
메소드의 접근 제어 수정(TODO: private으로 수정
)에 대해 작업이 필요합니다.sendMeetupPayedMail
및sendMeetupPayedEmail
)에서 전달되는kuddyNickname
,travelerNickname
변수를 사용하지 않고 있는데, 이 부분은 제거하거나 사용할 수 있도록 수정하는 것이 좋을 수 있습니다.