Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#101/게시글 댓글 #107

Merged
merged 30 commits into from
Aug 19, 2024
Merged

Feat/#101/게시글 댓글 #107

merged 30 commits into from
Aug 19, 2024

Conversation

arkchive
Copy link
Collaborator

@arkchive arkchive commented Aug 15, 2024

📝 요약

이슈 번호 : #101

🔖 변경 사항

  • 특정 게시글 댓글 조회
  • 댓글(대댓글) 생성
  • 댓글 좋아요

✅ 리뷰 요구사항

아직 완료되지 않은 pr 입니다!
제가 이슈를 댓글 조회, 생성 이렇게 쪼개지 못했네요
더 개발 후 완료되면 리뷰 요청 드리겠습니다! 참고해주세용
++ 변경사항만큼 진행했습니다 유효성 검사 로직이 완벽하지 않아서 추후에 수정 이슈를 통해 더 보완해보겠습니다!

📸 확인 방법 (선택)

포스트맨을 통해 테스트 완료 했습니다!


📌 PR 진행 시 이러한 점들을 참고해 주세요

* P1 : 꼭 반영해 주세요 (Request Changes) - 이슈가 발생하거나 취약점이 발견되는 케이스 등
* P2 : 반영을 적극적으로 고려해 주시면 좋을 것 같아요 (Comment)
* P3 : 이런 방법도 있을 것 같아요~ 등의 사소한 의견입니다 (Chore)

@arkchive arkchive linked an issue Aug 15, 2024 that may be closed by this pull request
@arkchive arkchive self-assigned this Aug 15, 2024
@PathVariable Long postId
) {
// TODO 1: 유저가 스페이스에 속하는 지 검증
commentService.validateUserInSpace(userId, spaceId);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserSpaceValidateIntercpterUserSpaceValidateIntercpterURL 보시면 "/space/{spaceId}인 컨트롤러는 Interceptor 적용됩니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 반영했습니다!

@arkchive arkchive merged commit f355214 into develop Aug 19, 2024
3 checks passed
@hyunn522 hyunn522 deleted the feat/#101/게시글-댓글 branch September 2, 2024 14:46
seongjunnoh pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 게시글 댓글
2 participants