Hotfix/#117: lastUpdate 반환값 및 시간대 기준 위치 수정 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongjunnoh
reviewed
Aug 18, 2024
저도 생성일 response에 담아 보내는 부분의 코드를 LocalDateTime 형식으로 변경 & 시간대 변경 하여 push 했습니다! |
drbug2000
approved these changes
Aug 18, 2024
seongjunnoh
approved these changes
Aug 18, 2024
| @@ -119,7 +119,7 @@ public ReadChatRoomMemberResponse readChatRoomMembers(Long spaceId, Long chatRoo | |||
| UserSpace userSpace = userSpaceDao.findUserSpaceByUserAndSpace(user, spaceById) | |||
| .orElseThrow(() -> new CustomException(USER_IS_NOT_IN_SPACE)); | |||
|
|
|||
| userList.add(new UserInfoInSpace(user.getUserId(), user.getUserName(), userSpace.getUserProfileImg(), user.getSignupType())); | |||
| userList.add(new UserInfoInSpace(user.getUserId(), user.getUserName(), userSpace.getUserProfileImg(), userSpace.getUserSpaceAuth())); | |||
| }); | |||
| List<ChatRoom> activeChatRooms = chatRoomList.stream() | ||
| .filter(userChatRoom -> "ACTIVE".equals(userChatRoom.getStatus())) | ||
| .toList(); | ||
|
|
There was a problem hiding this comment.
ACTIVE 만 조회하는 로직 좋습니다
| chatRoomByChatRoomId.updateInactive(); | ||
|
|
||
| // TODO 3: DB에 변경 사항 저장 | ||
| chatRoomDao.save(chatRoomByChatRoomId); | ||
|
|
There was a problem hiding this comment.
엔티티의 필드값을 update 한 후, 다시 dao단에서 persist를 하지않아도 jpa가 자동으로 db에 변경사항을 반영해 주는 것으로 알고 있습니다!
There was a problem hiding this comment.
저도 그렇게 알고 있었는데 기존대로 save 없이는 db에 반영이 되지 않더라구요..
정확한 이유는 모르겠으나 일단 구현을 위해 추가했습니다
| @@ -177,8 +191,12 @@ public ChatSuccessResponse deleteChatRoom(Long chatRoomId) { | |||
| ChatRoom chatRoomByChatRoomId = chatRoomDao.findById(chatRoomId) | |||
| .orElseThrow(() -> new CustomException(CHATROOM_NOT_EXIST)); | |||
|
|
|||
| // TODO 2: 해당 chatRoom inactive로 변경 | |||
| chatRoomByChatRoomId.updateInactive(); | |||
|
|
|||
There was a problem hiding this comment.
오호 이 status update 메서드는 유용하게 쓰일거 같네요!
seongjunnoh
pushed a commit
that referenced
this pull request
Oct 30, 2024
Hotfix/#117: lastUpdate 반환값 및 시간대 기준 위치 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 요약
🔖 변경 사항
이슈에 기재한 설명 참고 부탁드립니다
✅ 리뷰 요구사항
LocalDateTime 처리하는 부분에서 기준을 seoul로 맞추는 걸 누락한 부분이 있더라구요
다른 분들도 담당 도메인에서 한 번 체크해주시면 좋을 것 같습니다
📸 확인 방법 (선택)
📌 PR 진행 시 이러한 점들을 참고해 주세요