Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type assertions and casts to fix mypy issues #168

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

johannesring
Copy link
Collaborator

This pull request addresses several issues reported by mypy by adding necessary type assertions and casts. Fixes issue #167.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (438ffff) to head (b69921b).

Files Patch % Lines
src/vasp/automatedPostprocessing/log_plotter.py 66.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   79.02%   78.95%   -0.08%     
==========================================
  Files          32       32              
  Lines        3771     3777       +6     
==========================================
+ Hits         2980     2982       +2     
- Misses        791      795       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@keiyamamo keiyamamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the fix!

@johannesring johannesring merged commit 55a0613 into master Jul 17, 2024
5 checks passed
@johannesring johannesring deleted the johannr/mypy-fixes branch July 17, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants