Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mypy happy #194

Merged
merged 2 commits into from
Oct 17, 2024
Merged

make mypy happy #194

merged 2 commits into from
Oct 17, 2024

Conversation

keiyamamo
Copy link
Collaborator

This pull request introduces several assertions to ensure that certain variables are not None before they are used.
mypy started complaining about those variables in CI.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (7915b55) to head (319f126).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files          32       32           
  Lines        3848     3848           
=======================================
  Hits         3024     3024           
  Misses        824      824           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keiyamamo keiyamamo merged commit 9326a44 into KVSlab:master Oct 17, 2024
5 checks passed
@keiyamamo keiyamamo deleted the fix_mypy branch October 21, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants