Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two points in the current CFL number computation.
The minimum cell diameter was computed from rank 0 only in the previous implementation. By using
MPI.min
, we now get the minimum cell diameter from all the ranks. Technically, we should use the local cell diameter to compute CFL number, but we stay in the safe range by using the minimum cell diameter and also is computationally efficient.The current implementation does not take velocity degree in account. Although I couldn’t find a formal definition of CFL number with higher order elements, there are some papers addressing order dependency of the CFL number, such as this one. Might not be mathematically perfect way of computing CFL, but this new implementation addresses this issue by using
v.ufl_element().degree()