Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unicode \ll and \lll #1273

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Support Unicode \ll and \lll #1273

merged 2 commits into from
Apr 25, 2018

Conversation

ronkok
Copy link
Collaborator

@ronkok ronkok commented Apr 24, 2018

Fixes #1272. Consistent with unicode-math

Fixes #1272. Consistent with `unicode-math`
@codecov
Copy link

codecov bot commented Apr 24, 2018

Codecov Report

Merging #1273 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1273   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files          60       60           
  Lines        3880     3880           
  Branches      651      651           
=======================================
  Hits         3199     3199           
  Misses        578      578           
  Partials      103      103
Impacted Files Coverage Δ
src/symbols.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812b350...c3e29c2. Read the comment docs.

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response to this issue.

@@ -2976,7 +2976,7 @@ describe("Unicode", function() {
});

it("should parse relations", function() {
expect("∈∋∝∼∽≂≃≅≈≊≍≎≏≐≑≒≓≖≗≜≡≤≥≦≧≫≬≳≷≺≻≼≽≾≿∴∵∣≔≕⩴").toParse();
expect("∈∋∝∼∽≂≃≅≈≊≍≎≏≐≑≒≓≖≗≜≡≤≥≦≧≫≬≳≷≺≻≼≽≾≿∴∵∣≔≕⩴≪⋘").toParse();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put beside the ? There should also be \ggg can you add the unicode char for that beside the ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@kevinbarabash kevinbarabash merged commit b4b57cb into KaTeX:master Apr 25, 2018
@ronkok ronkok deleted the lll branch April 25, 2018 01:08
@edemaine
Copy link
Member

That was fast! Thanks @ronkok and @kevinbarabash!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants