Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten a bunch of non-pervasive ParseNode types (part 2) #1552

Merged
merged 16 commits into from
Aug 6, 2018

Conversation

marcianx
Copy link
Collaborator

@marcianx marcianx commented Aug 6, 2018

Towards #1492.

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #1552 into master will increase coverage by 0.01%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1552      +/-   ##
==========================================
+ Coverage    84.1%   84.12%   +0.01%     
==========================================
  Files          79       79              
  Lines        4555     4554       -1     
  Branches      803      803              
==========================================
  Hits         3831     3831              
+ Misses        629      628       -1     
  Partials       95       95
Impacted Files Coverage Δ
src/functions/environment.js 100% <ø> (ø) ⬆️
src/parseNode.js 84.21% <ø> (ø) ⬆️
src/utils.js 66.66% <0%> (ø) ⬆️
src/functions/underline.js 9.09% <0%> (+0.75%) ⬆️
src/buildHTML.js 97.69% <0%> (ø) ⬆️
src/functions/overline.js 25% <0%> (ø) ⬆️
src/Parser.js 93.94% <100%> (ø) ⬆️
src/functions/operatorname.js 92.1% <100%> (ø) ⬆️
src/functions/enclose.js 90.76% <100%> (ø) ⬆️
src/functions/raisebox.js 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1506dc1...903f19e. Read the comment docs.

@ylemkimon ylemkimon merged commit 5b6ffd7 into KaTeX:master Aug 6, 2018
@marcianx marcianx deleted the flatten2 branch August 6, 2018 12:54
Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks for doing all of these refactors. I'm glad to see that you're able to do them in chunks.

value: AnyParseNode[],
|},
color: string,
body: AnyParseNode[],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@kevinbarabash
Copy link
Member

@ylemkimon thanks for reviewing all of these large refactors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants