-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten a bunch of non-pervasive ParseNode types (part 2) #1552
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
+ Coverage 84.1% 84.12% +0.01%
==========================================
Files 79 79
Lines 4555 4554 -1
Branches 803 803
==========================================
Hits 3831 3831
+ Misses 629 628 -1
Partials 95 95
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Thanks for doing all of these refactors. I'm glad to see that you're able to do them in chunks.
value: AnyParseNode[], | ||
|}, | ||
color: string, | ||
body: AnyParseNode[], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better!
@ylemkimon thanks for reviewing all of these large refactors. |
Towards #1492.