Re-enable \includegraphics #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5806b24.
Codecov Report
@@ Coverage Diff @@
## master #2053 +/- ##
==========================================
+ Coverage 93.33% 95.06% +1.73%
==========================================
Files 80 80
Lines 5024 5024
Branches 887 887
==========================================
+ Hits 4689 4776 +87
+ Misses 294 224 -70
+ Partials 41 24 -17
Continue to review full report at Codecov.
|
|
Thanks for re-enabling this functionality and for tweaking |
ylemkimon
approved these changes
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2027 by re-enabling
\includegraphics, now thattrustsetting (#1794) has merged. I reverted 5806b24 and checked old versions of #1794 for anything else to add. I added some snapshot tests similar to those for\urland\href, and cleanedWhile I was here, also fix #1892 by including the
\includegraphicsimage locally for testing (and use it on the website).Not directly related: I modified the
yarn startinteractive test website to settrusttotrueby default, like it is on the katex.org demo, because the assumption is that someone entering text manually is doing so in a trustworthy fashion. I added atrust=0option for testing that things break whentrustisfalse.