This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
Fix some animation issues #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GF's hair loop - Fix parents eye loop - Play regular singing animation if the alt version doesn't exist
|
Unsure why bf-car idle loop isn't working as it should, currently looking into it |
Spel0
reviewed
Oct 24, 2021
source/PlayState.hx
Outdated
| @@ -2976,7 +2976,10 @@ class PlayState extends MusicBeatState | |||
| if (daNote.spotInLine != daNote.parent.children.length - 1) | |||
| { | |||
| var singData:Int = Std.int(Math.abs(daNote.noteData)); | |||
| dad.playAnim('sing' + dataSuffix[singData] + altAnim, true); | |||
| if (dad.animation.getByName('sing' + dataSuffix[singData] + altAnim) != null) | |||
There was a problem hiding this comment.
This is exactly what this line does?
I see no reason to add this since it does the same thing with the difference of the one in character.hx being that prints into debug console that such animation doesn't exist.
There was a problem hiding this comment.
Oh, I didn't notice that...
There was a problem hiding this comment.
Though I can see why I didn't notice it, I'm currently working on a mod that's based off an older KE version: 1.4.2 infact.
Spel0
reviewed
Oct 24, 2021
source/PlayState.hx
Outdated
| @@ -3010,7 +3013,10 @@ class PlayState extends MusicBeatState | |||
| else | |||
| { | |||
| var singData:Int = Std.int(Math.abs(daNote.noteData)); | |||
| dad.playAnim('sing' + dataSuffix[singData] + altAnim, true); | |||
| if (dad.animation.getByName('sing' + dataSuffix[singData] + altAnim) != null) | |||
Spel0
reviewed
Oct 24, 2021
source/PlayState.hx
Outdated
| @@ -4357,7 +4363,10 @@ class PlayState extends MusicBeatState | |||
| trace("Alt note on BF"); | |||
| } | |||
|
|
|||
| boyfriend.playAnim('sing' + dataSuffix[note.noteData] + altAnim, true); | |||
| if (boyfriend.animation.getByName('sing' + dataSuffix[note.noteData] + altAnim) != null) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of video previews
Dad:2021-10-23_21-22-43.mp4
Mom:
2021-10-23_21-22-58.mp4
Parents:
2021-10-23_21-23-11.mp4
Girlfriend (Car):
2021-10-23_21-35-20.mp4