Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CFrame.fromMatrix call with three arguments #113

Closed
NPhrd opened this issue May 11, 2020 · 0 comments · Fixed by #117
Closed

Allow CFrame.fromMatrix call with three arguments #113

NPhrd opened this issue May 11, 2020 · 0 comments · Fixed by #117
Labels
A-roblox Area: Roblox specific A-standard-library Area: Standard Library C-bug Category: Bug E-easy Call for participation: Experience needed to fix: Easy / not much

Comments

@NPhrd
Copy link

NPhrd commented May 11, 2020 •
edited
Loading

CFrame.fromMatrix(pos, vX, vY)
This is valid usage of fromMatrix where vZ will be deduced as vX:Cross(vY).Unit
@Kampfkarren Kampfkarren added A-roblox Area: Roblox specific A-standard-library Area: Standard Library C-bug Category: Bug E-easy Call for participation: Experience needed to fix: Easy / not much labels May 11, 2020
@Jaguar-515 Jaguar-515 mentioned this issue Jun 12, 2020
Merged
Kampfkarren added a commit that referenced this issue Jun 12, 2020
@Jaguar-515 @Kampfkarren
Change 4th argument to CFrame.fromMatrix optional (#117)
4be3470 
* Change 4th argument to CFrame.fromMatrix optional  (#113)

* Update CHANGELOG.md

* Formatted CFrame.fromMatrix correctly

oops. didn't notice that

* Fix typo

Co-authored-by: boyned//Kampfkarren <boynedmaster@gmail.com>

Co-authored-by: boyned//Kampfkarren <boynedmaster@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-roblox Area: Roblox specific A-standard-library Area: Standard Library C-bug Category: Bug E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change 4th argument to CFrame.fromMatrix optional
2 participants
@Kampfkarren @NPhrd