fix(tests): Update FlowTypeSelector data-testid

KaotoIO · May 28, 2024 · a3c1b53 · a3c1b53
1 parent 598d9ce
commit a3c1b53
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 14 deletions.
diff --git a/packages/ui-tests/cypress/e2e/designer/multiflow/multiFlowDesigner.cy.ts b/packages/ui-tests/cypress/e2e/designer/multiflow/multiFlowDesigner.cy.ts
@@ -15,6 +15,7 @@ describe('Test for Multi route actions from the canvas', () => {
   it('User shows and hides a route', () => {
     cy.addNewRoute();
     cy.addNewRoute();
+    cy.addNewRoute();
 
     cy.get('[data-testid="flows-list-route-count"]').should('have.text', '1/3');
 
@@ -59,6 +60,7 @@ describe('Test for Multi route actions from the canvas', () => {
     cy.openDesignPage();
     cy.addNewRoute();
     cy.addNewRoute();
+    cy.addNewRoute();
     cy.showAllRoutes();
 
     cy.get('[data-testid="flows-list-route-count"]').should('have.text', '3/3');
@@ -94,7 +96,6 @@ describe('Test for Multi route actions from the canvas', () => {
 
   it('User creates multiple CamelRoute type routes in canvas', () => {
     // Camel Route is set as default type - simply add new routes
-    cy.deleteRoute(0);
     cy.addNewRoute();
     cy.addNewRoute();
     cy.addNewRoute();

diff --git a/packages/ui-tests/cypress/support/next-commands/default.ts b/packages/ui-tests/cypress/support/next-commands/default.ts
@@ -25,7 +25,7 @@ Cypress.Commands.add('expandVisualization', () => {
 Cypress.Commands.add('openDesignPage', () => {
   cy.expandVisualization();
   cy.get('[data-testid="Design"]').click();
-  cy.get('[data-test-id="topology"]').should('be.visible');
+  cy.get('.pf-topology-container').should('be.visible');
 });
 
 Cypress.Commands.add('openSourceCode', () => {

diff --git a/packages/ui/src/components/Visualization/Canvas/__snapshots__/Canvas.test.tsx.snap b/packages/ui/src/components/Visualization/Canvas/__snapshots__/Canvas.test.tsx.snap
@@ -376,7 +376,7 @@ exports[`Canvas Empty state should render empty state when there is no visual en
                       <button
                         aria-expanded="false"
                         class="pf-v5-c-menu-toggle__button"
-                        data-testid="dsl-list-dropdown"
+                        data-testid="viz-dsl-list-dropdown"
                         type="button"
                       >
                         <span

diff --git a/packages/ui/src/components/Visualization/EmptyState/FlowType/FlowTypeSelector.test.tsx b/packages/ui/src/components/Visualization/EmptyState/FlowType/FlowTypeSelector.test.tsx
@@ -41,7 +41,7 @@ const FlowTypeSelectorWithContext: React.FunctionComponent<{ currentSchemaType?:
 describe('FlowTypeSelector.tsx', () => {
   test('component renders', () => {
     const wrapper = render(<FlowTypeSelectorWithContext />);
-    const toggle = wrapper.queryByTestId('dsl-list-dropdown');
+    const toggle = wrapper.queryByTestId('viz-dsl-list-dropdown');
     expect(toggle).toBeInTheDocument();
   });
 
@@ -70,7 +70,7 @@ describe('FlowTypeSelector.tsx', () => {
 
   test('should toggle list of DSLs', async () => {
     const wrapper = render(<FlowTypeSelectorWithContext />);
-    const toggle = await wrapper.findByTestId('dsl-list-dropdown');
+    const toggle = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {
@@ -90,7 +90,7 @@ describe('FlowTypeSelector.tsx', () => {
 
   test('should show list of DSLs', async () => {
     const wrapper = render(<FlowTypeSelectorWithContext />);
-    const toggle = await wrapper.findByTestId('dsl-list-dropdown');
+    const toggle = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {
@@ -103,7 +103,7 @@ describe('FlowTypeSelector.tsx', () => {
 
   test('should disable a SelectOption if is already selected and does not support multiple flows', async () => {
     const wrapper = render(<FlowTypeSelectorWithContext currentSchemaType={SourceSchemaType.Pipe} />);
-    const toggle = await wrapper.findByTestId('dsl-list-dropdown');
+    const toggle = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {
@@ -119,7 +119,7 @@ describe('FlowTypeSelector.tsx', () => {
 
   test('should show selected value', async () => {
     const wrapper = render(<FlowTypeSelectorWithContext />);
-    const toggle = await wrapper.findByTestId('dsl-list-dropdown');
+    const toggle = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {
@@ -144,7 +144,7 @@ describe('FlowTypeSelector.tsx', () => {
 
   test('should not have anything selected if "isStatic=true"', async () => {
     const wrapper = render(<FlowTypeSelectorWithContext />);
-    const toggle = await wrapper.findByTestId('dsl-list-dropdown');
+    const toggle = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {
@@ -170,7 +170,7 @@ describe('FlowTypeSelector.tsx', () => {
 
   test('should have selected DSL if provided', async () => {
     const wrapper = render(<FlowTypeSelectorWithContext />);
-    const toggle = await wrapper.findByTestId('dsl-list-dropdown');
+    const toggle = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {
@@ -186,7 +186,7 @@ describe('FlowTypeSelector.tsx', () => {
 
   test('should close Select when pressing ESC', async () => {
     const wrapper = render(<FlowTypeSelectorWithContext />);
-    const toggle = await wrapper.findByTestId('dsl-list-dropdown');
+    const toggle = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {

diff --git a/packages/ui/src/components/Visualization/EmptyState/FlowType/FlowTypeSelector.tsx b/packages/ui/src/components/Visualization/EmptyState/FlowType/FlowTypeSelector.tsx
@@ -66,7 +66,7 @@ export const FlowTypeSelector: FunctionComponent<ISourceTypeSelector> = (props)
 
   const toggle = (toggleRef: Ref<MenuToggleElement>) => (
     <MenuToggle
-      data-testid="dsl-list-dropdown"
+      data-testid="viz-dsl-list-dropdown"
       ref={toggleRef}
       onClick={onToggleClick}
       isExpanded={isOpen}

diff --git a/packages/ui/src/components/Visualization/EmptyState/FlowType/NewFlow.test.tsx b/packages/ui/src/components/Visualization/EmptyState/FlowType/NewFlow.test.tsx
@@ -54,7 +54,7 @@ describe('NewFlow.tsx', () => {
 
   it('should render all of the types', async () => {
     const wrapper = renderWithContext();
-    const trigger = await wrapper.findByTestId('dsl-list-dropdown');
+    const trigger = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {
@@ -69,7 +69,7 @@ describe('NewFlow.tsx', () => {
 
   it('should warn the user when adding a different type of flow', async () => {
     const wrapper = renderWithContext();
-    const trigger = await wrapper.findByTestId('dsl-list-dropdown');
+    const trigger = await wrapper.findByTestId('viz-dsl-list-dropdown');
 
     /** Open Select */
     act(() => {