Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: saving videos and screenshots for e2e tests only on failure #1437

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

apupier
Copy link
Member

@apupier apupier commented Sep 17, 2024

the limit of storage is not far. Most of the place is took by the videos and screenshots of the e2e tests. We are usually looking at them only on failure. This should save a lot of space.

the limit of storage is not far. Most of the place is took by the videos
and screenshots of the e2e tests. We are usually looking at them only on
failure. This should save a lot of space.

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Copy link

sonarcloud bot commented Sep 17, 2024

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for @tplevko confirmation and we're good to go

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@972d250). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1437   +/-   ##
=======================================
  Coverage        ?   67.53%           
  Complexity      ?       25           
=======================================
  Files           ?      266           
  Lines           ?     7601           
  Branches        ?     1509           
=======================================
  Hits            ?     5133           
  Misses          ?     2408           
  Partials        ?       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip merged commit 06ecb09 into KaotoIO:main Sep 17, 2024
12 checks passed
@apupier apupier deleted the storeVideosonlyOnError branch September 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants