Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1428): add support for multiValue #1440

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix(1428): add support for multiValue #1440

merged 1 commit into from
Sep 18, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Sep 17, 2024

fixes #1428

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9b7cd80). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...on/flows/support/camel-component-schema.service.ts 89.74% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1440   +/-   ##
=======================================
  Coverage        ?   68.32%           
  Complexity      ?       25           
=======================================
  Files           ?      269           
  Lines           ?     7698           
  Branches        ?     1530           
=======================================
  Hits            ?     5260           
  Misses          ?     2385           
  Partials        ?       53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tplevko tplevko force-pushed the issue_1428 branch 2 times, most recently from cb49e5a to 8c90534 Compare September 18, 2024 07:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tplevko tplevko marked this pull request as ready for review September 18, 2024 07:32
lordrip
lordrip approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tplevko

@lordrip lordrip merged commit 1fdc923 into KaotoIO:main Sep 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiValue is not supported
2 participants
@tplevko @lordrip