Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build instructions? #2

Closed
guihkx opened this issue Mar 16, 2019 · 7 comments
Closed

Build instructions? #2

guihkx opened this issue Mar 16, 2019 · 7 comments

Comments

@guihkx
Copy link

guihkx commented Mar 16, 2019

I've been using your patched fonts for a long while on Arch Linux (and absolutely I love them, thanks). But a recent update of the freetype2 package, from version 2.9.1 to version 2.10.0, somehow "broke" your patched font. I've tried downgrading freetype2 back to 2.9.1, but Chromium completely breaks so unfortunately that's not an option... Anyway, here's a quick comparison:

Monaco Nerd Fonts (freetype2 2.9.1):

terminal-freetype-old

Monaco Nerd Fonts (freetype2 2.10.0):

terminal-freetype-new

As you can see from the screenshots above, the "line height" on version 2.10.0 seems substantially smaller when compared to version 2.9.1. So I was wondering if you could help me by telling me:

  • Where did you get your Monaco.{ttf,otf} font?
  • What options (arguments) did you use in font-patcher from nerd-fonts?

I just wanna see if building it myself using the latest freetype2 version will change anything.

Thanks a lot.

@Karmenzind
Copy link
Owner

Karmenzind commented Mar 17, 2019

Hi. I ran pacman -Syu one minite ago and it broke my font too, looked just like your second picture. And for now I have no idea how to fix it. Sorry.

Didn't remember where to get the original font. The options should simply be: -c (maybe with --careful). I never dig into how the patcher worked. Sorry for that again.

So if you found a solution, please let me know. Thank you very much.

@Karmenzind
Copy link
Owner

I searched monaco and got these repos:
https://github.com/todylu/monaco.ttf
https://github.com/cstrap/monaco-font
Hope it can help you.
I'll try to do the repatching at my leisure.

@guihkx
Copy link
Author

guihkx commented Mar 17, 2019

Thanks for the links.

Yesterday I tried patching some monaco fonts I found on Github. The first one you linked didn't work for me, fontforge threw a bunch of errors I didn't know how to fix / ignore. Then I came across this MonacoB font (more specifically, the MonacoBSemi variant).

Then I created a PKGBUILD for it, based on a copy of ttf-nerd-fonts-input, applied the patch and I think it looks almost exactly like before!

Here's the PKGBUILD (beware, it downloads the entire nerd-fonts repo, it's about 2 GB):
Here's the AUR package:

https://aur.archlinux.org/packages/otf-nerd-fonts-monacob-mono/

And here how it looks now on Konsole with freetype2 2.10.0:

image

Although it already looks great (for me), I think I will try with some other Monaco fonts (like the second one you linked) when I have some free time. Thanks

@Karmenzind
Copy link
Owner

Karmenzind commented Mar 18, 2019

Good job. Thank you.
I'll try your PKGBUILD later after getting home.
I read the patcher's script and found downloading https://github.com/ryanoasis/nerd-fonts/tree/master/src/glyphs will be fairly enough according to this line:
https://github.com/ryanoasis/nerd-fonts/blob/master/font-patcher#L761

You can download the directory by:

# replace 'tree/master' with 'trunk'
svn checkout https://github.com/ryanoasis/nerd-fonts/trunk/src/glyphs

But I don't know how to write this into PKGBUILD.

Karmenzind added a commit that referenced this issue Mar 18, 2019
@guihkx
Copy link
Author

guihkx commented Mar 18, 2019

Thanks a lot for the tips! I've created a new PKGBUILD and submitted to the AUR:

https://aur.archlinux.org/packages/otf-nerd-fonts-monacob-mono/

I decided to go keep the MonacoB fonts, because every other one I tried didn't look as good. Let me know if it works for you.

You can also close this if you want.

@Karmenzind
Copy link
Owner

Glad to try it later. Too busy these days. 😫

@guihkx
Copy link
Author

guihkx commented Mar 20, 2019

No problem, thanks for everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants