Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for Nerd Fonts v3 (a breaking change) #9

Merged
merged 4 commits into from
May 30, 2023
Merged

Build for Nerd Fonts v3 (a breaking change) #9

merged 4 commits into from
May 30, 2023

Conversation

hjdarnel
Copy link
Contributor

Nerd Fonts recently released a v3 which is causing plugins that use a Nerd Font to upgrade. Unfortunately this means if you don't have an updated v3 Nerd Font, stuff starts breaking (like here).

I removed the now unnecessary --also-windows flag from the build script, as both fonts should now be Windows compatible (see here for that change). I also rebuilt the font and validated that it works correctly after installing.

@hjdarnel
Copy link
Contributor Author

@Karmenzind tagging you in case you weren't notified

@Karmenzind
Copy link
Owner

sorry for the late
I will check and merge it soon

@Karmenzind Karmenzind merged commit 7815109 into Karmenzind:master May 30, 2023
@Karmenzind
Copy link
Owner

@hjdarnel Thanks for your work!
I want to know what original font file are you using? https://www.fontmirror.com/monaco or another one? Please give me the source link.

@hjdarnel
Copy link
Contributor Author

@Karmenzind I pulled it from my system fonts (on macOS) so fontmirror.com should be a good link to it.

@hjdarnel hjdarnel deleted the upgrade-v3 branch May 30, 2023 15:30
@Karmenzind
Copy link
Owner

@hjdarnel thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants