Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NOT NULL constraint to descriptions #42

Closed
lnschroeder opened this issue Jul 12, 2023 · 2 comments · Fixed by #46
Closed

Add NOT NULL constraint to descriptions #42

lnschroeder opened this issue Jul 12, 2023 · 2 comments · Fixed by #46

Comments

@lnschroeder
Copy link
Contributor

Motivation
It would be great if it was possible to to visualize NOT NULL constraints.

Solution
Unfortunately, Mermaid does not support special characters (such as asterisks) in the name column.
Instead the comment column could be used (as suggested here).

To toggle this, notNull could be added to the showDescription flag e.g.

showDescriptions:
  - columnComments
  - enumValues
  - notNull

image

I am happy to make a PR for this.

All feedback is welcome :)
@KarnerTh
Copy link
Owner

Totally agree!

Feel free to create a PR :) I am on vacation, but as soon as I am back I will review it

@lnschroeder lnschroeder mentioned this issue Jul 26, 2023
Merged
KarnerTh pushed a commit that referenced this issue Aug 6, 2023
@lnschroeder
Add NOT NULL constraint (#46)
4ff9592 
* Add not null constraint (#42)

* Fix spacing between AttributeKey and Description
@KarnerTh
Copy link
Owner

KarnerTh commented Aug 6, 2023

Change is available in version 0.9.0.

Thanks for your contribution 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NOT NULL constraint
2 participants
@KarnerTh @lnschroeder