Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast outline.tags to char * to fix FreeType 2.13.3 build #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fwcd
Copy link
Contributor

@fwcd fwcd commented Sep 3, 2024

Unfortunately, AGG no longer builds with FreeType 2.13.3 as FT_Outline changed some of its members from char * to unsigned char * (compare the 2.13.2 docs with the current docs):

swiftplot/Sources/AGG/agg_font_freetype.cpp:182:35: error: assigning to 'char *' from 'unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not
            tags  = outline.tags  + first;
                    ~~~~~~~~~~~~~~^~~~~~~

This PR patches the issue by adding a cast, which should work on both 2.13.2 (or older) and 2.13.3. Once fixed upstream, the AGG sources could be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant