Tech sanity tests #452
Merged
Tech sanity tests #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Areyana
requested review from
AzamatCherchesov,
eakurnikov,
RuslanMingaliev and
Nikitae57
as code owners
|
|
|
Ilya Dziamidovich seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit b9bfc84.
|
Do you need any help implementing specific features? I might be able to offer some advice. |
# Conflicts: # samples/kaspresso-sample/src/androidTest/kotlin/com/kaspersky/kaspressample/screen/MainScreen.kt # samples/kaspresso-sample/src/main/AndroidManifest.xml # samples/kaspresso-sample/src/main/kotlin/com/kaspersky/kaspressample/MainActivity.kt # samples/kaspresso-sample/src/main/res/layout/activity_main.xml # samples/kaspresso-sample/src/main/res/values-ru/strings.xml # samples/kaspresso-sample/src/main/res/values/strings.xml
Areyana
commented
Jul 31, 2023
kaspresso/src/main/kotlin/com/kaspersky/kaspresso/systemsafety/SystemDialogSafetyPattern.kt
Show resolved
Hide resolved
Nikitae57
previously approved these changes
Aug 1, 2023
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| window.addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON) |
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| window.addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON) |
Nikitae57
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #439
Old \Sgoogle.android\S can't cover all cases that we need, so i'm adding SystemSafetyPattern enum with multiple patterns, which anyone can extend.
Sanity tests that cover interceptors logic, except autoscroll compose that will be part of new compose features PR.