Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v3-parser): Export metadata for method.param items (#39) #40

Merged
merged 2 commits into from
Nov 30, 2020
Merged

fix(v3-parser): Export metadata for method.param items (#39) #40

merged 2 commits into from
Nov 30, 2020

Conversation

soft-decay
Copy link
Contributor

  • Parse @param from JSDoc
  • Add function getDefaultJSDocType
  • Update tests for svelte3/integration/methods
  • Fix typings for SvelteMethodItem
  • Add example usage

@soft-decay
fix(v3-parser): Export metadata for method.param items (KatChaotic#39)
f863a48 
- Add function getDefaultJSDocType
- Update tests for svelte3/integration/methods
- Fix typings for SvelteMethodItem
- Add example usage
alexprey
alexprey approved these changes Nov 29, 2020
View reviewed changes
Copy link
Collaborator

@alexprey alexprey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR

@alexprey alexprey added this to the 4.0.0 milestone Nov 29, 2020
@soft-decay
fix(parser, v3-parser): Remove depracated keys from api
c1eeb18 
- Remove 'value' => Use 'importPath'
- Remove 'loc' => Use 'locations'
- Remove 'args' => Use 'params'
- Refactor parseKeywords
- Fix tests for svelte2/integration/locations
- Fix input file for svelte2/integration/overall
- Fix typings for removed keys
- Lint for svelte3/integration/components
- Lint svelte3/integration/methods
- Lint unit/jsdoc
@soft-decay
Copy link
Contributor Author

soft-decay commented Nov 30, 2020 •
edited
Loading

I removed deprecated keys from both parsers. You can check the commit message for details. I had to refactor parseKeywords because the linting rules prevented me from making declarations in the switch case. [Ref #41]

@soft-decay soft-decay mentioned this pull request Nov 30, 2020
Closed
alexprey
alexprey approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@alexprey alexprey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@alexprey alexprey merged commit afb6115 into KatChaotic:master Nov 30, 2020
@soft-decay soft-decay mentioned this pull request Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprey alexprey alexprey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@soft-decay @alexprey