Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert opacity setting #370

Closed
Katsute opened this issue Jul 22, 2024 · 0 comments · Fixed by #379
Closed

Invert opacity setting #370

Katsute opened this issue Jul 22, 2024 · 0 comments · Fixed by #379

Comments

@Katsute
Copy link
Member

Katsute commented Jul 22, 2024

Feature

Change the opacity setting to reflect the opacity of the background and not 1 - opacity

This is a breaking change! there are a few ways we can migrate old data:

  • Add a new opacity field and migrate the existing value over. Skip if a opacity value is already set or existing is not set
  • Toggleable bool to use inverted opacity behavior, set to true if the existing value is already set < have a legacy period of 6 months before we migrate and remove it (how to only run once?)

A notice is needed before this change.

Reason

To achieve parity with other background extensions and common sense

@Katsute Katsute self-assigned this Jul 22, 2024
@Katsute Katsute added the v3 label Jul 22, 2024
@Katsute Katsute added this to the M3 milestone Aug 10, 2024
@kdevbot kdevbot bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant