-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert opacity setting #379
Conversation
Use globalState to keep track if the migration process ran. Use a key like Migration logic must exist permanently so users that don't update for a long period still keep their settings. On first launch:
|
Setting logic from #383 needs to be merged first so we can use it to check if opacity setting is set instead of falling back to the default |
On update, VS complains that the manifest doesn't contain the new option, all while it IS using the updated code Need to test with install/uninstall then new ver |
✅ Install/Uninstall + VSIX Load passed |
show notification on migrate show notification on missing option (vscode bug) - prompt to reload |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by @Katsute
Relevant Issues
List any closed and/or relevant issues
Changes Made
List any changes made.
Release Notes
Going forward, to achieve parity with other background extensions, the opacity calculation will be switched from 0 visible and 1 invisible to 1 visible and 0 invisible.
To use the old behavior, use the useInvertedOpacity option. If you already have an opacity set, the inverted opacity setting will automatically be turned on.