Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept background images from URLs #35

Merged
merged 11 commits into from
Sep 11, 2022
Merged

Accept background images from URLs #35

merged 11 commits into from
Sep 11, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Sep 10, 2022 •
edited
Loading

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

Release Notes

  • Image URLs must be served over HTTPS
  • File URLs (file://) do not work, use Add File or Add Folder option

@Katsute Katsute self-assigned this Sep 10, 2022
@Katsute
Copy link
Member Author

Katsute commented Sep 10, 2022

  • Image must be served over HTTPS
  • If user provides file:// refer them to add file/folder methods

@Katsute Katsute changed the title Add ability to use image URLs as backgrounds Accept background images from URLs Sep 11, 2022
@Katsute Katsute marked this pull request as ready for review September 11, 2022 16:42
@Katsute
Copy link
Member Author

Katsute commented Sep 11, 2022

@mashiro-san approve this pull

ghost
ghost approved these changes Sep 11, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit f6ac207 into main Sep 11, 2022
@Katsute Katsute deleted the image-url@638ac93 branch September 11, 2022 20:02
@ghost ghost locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@Katsute Katsute

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept Image URLs
1 participant
@Katsute