Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extension compatibility with VSCode 1.94 for Mac #410

Merged
merged 37 commits into from
Sep 13, 2024
Merged

Fix extension compatibility with VSCode 1.94 for Mac #410

merged 37 commits into from
Sep 13, 2024

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Sep 12, 2024 •
edited
Loading

Relevant Issues

List any closed and/or relevant issues

Changes Made

List any changes made.

  • Tests for linux and macos
  • Fix directory on mac

If this breaks in the future, will need to use process.cwd(), unfortunately does not work on Mac

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 12, 2024
View reviewed changes
src/extension.ts Fixed Show fixed Hide fixed
@Katsute Katsute self-assigned this Sep 12, 2024
@Katsute Katsute changed the title Main@3f2ee91 Fix compatibility with VSCode 1.84 for Mac Sep 12, 2024
@Katsute
Copy link
Member Author

Katsute commented Sep 13, 2024

Verified working on Linux

@Katsute
Copy link
Member Author

Katsute commented Sep 13, 2024

Tests are working, Mac is failing because process.cwd() is blank

@Katsute
Copy link
Member Author

Katsute commented Sep 13, 2024

VERIFIED working on Win + Linux + MacOS

@Katsute

This comment has been minimized.

Sign in to view
kdevbot[bot]
kdevbot bot previously approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@kdevbot kdevbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute
Copy link
Member Author

Katsute commented Sep 13, 2024

Pending final test, will reverify tomorrow

@Katsute
Copy link
Member Author

Katsute commented Sep 13, 2024 •
edited
Loading

Pending Tests:

  • Windows - Stable ✅
  • Windows - Insiders ✅
  • Linux - Stable ✅
  • MacOS - Stable ✅

@Katsute

This comment has been minimized.

Sign in to view
kdevbot[bot]
kdevbot bot approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@kdevbot kdevbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute : File confirmed existing on all OS

@Katsute Katsute added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 8ab339b Sep 13, 2024
10 checks passed
@Katsute Katsute deleted the main@3f2ee91 branch September 13, 2024 23:49
@kdevbot kdevbot bot locked and limited conversation to collaborators Sep 13, 2024
@Katsute Katsute changed the title Fix compatibility with VSCode 1.84 for Mac Fix compatibility with VSCode 1.94 for Mac Sep 13, 2024
@Katsute Katsute changed the title Fix compatibility with VSCode 1.94 for Mac Fix extension compatibility with VSCode 1.94 for Mac Sep 13, 2024
@Katsute Katsute linked an issue Sep 14, 2024 that may be closed by this pull request
Commands not registering / Failed to find main file #408
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdevbot kdevbot kdevbot approved these changes

Assignees

@Katsute Katsute

Labels
critical issue macos vscode insiders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commands not registering / Failed to find main file
1 participant
@Katsute