Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Custom vesting curves #1

Closed
wants to merge 4 commits into from
Closed

WIP: Custom vesting curves #1

wants to merge 4 commits into from

Conversation

karzak
Copy link
Member

@karzak karzak commented Aug 27, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer

WIP:

  • Added account type for periodic vesting. This enables arbitrary vesting schedules.
  • Wrote tests in genaccounts and auth

TODO:

  • Figure out how to handle the client for periodic vesting accounts. Inputing an array of VestingPeriods to the cli seems sub-optimal.
  • Write tests in bank
  • Refactor structure to reflect general consensus that vesting should be moved out of auth.

Open questions:
How should I organize this? I'm not sure what a stand alone module or sub-module should look like, given that vesting accounts are a pretty minimal extension of account functionality. See cosmos#4486


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 23, 2021
@github-actions github-actions bot closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant