Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local git uri support for userPlugins and the abbility for userPlugins to specify their own derivation #40

Draft
wants to merge 118 commits into
base: main
Choose a base branch
from

Conversation

SpiderUnderUrBed
Copy link

This might not be fully finished, nor fully tested, I moved everything like regex to the top and separated github and git pattern matching, I removed coercion and instead did mapping later and used types.oneOf to choose from one of several pattern types such as package, path, git, GitHub.

TODO:
Right now I am not utilizing the rev I get from git, which I can use for version pinning.

I am open for suggestions on how to improve this.

@SpiderUnderUrBed
Copy link
Author

fixes #39

@SpiderUnderUrBed
Copy link
Author

I am having issues with the plugin being properly imported, maybe this is specific to the local git uri, further testing is needed.

@KaylorBen
Copy link
Owner

Sorry I've been busy for the past few days, Ill be able to look this over and maybe write some code for it in a couple days from now

@KaylorBen
Copy link
Owner

The original code for the plugins was taken from a user flake I found, so I don't fully understand how it works

SpiderUnderUrBed added a commit to SpiderUnderUrBed/nixcord that referenced this pull request Oct 28, 2024
@SpiderUnderUrBed SpiderUnderUrBed changed the title Add local git uri support for userPlugins Add local git uri support for userPlugins and the abbility for userPlugins to specify their own derivation Oct 29, 2024
@SpiderUnderUrBed
Copy link
Author

SpiderUnderUrBed commented Oct 29, 2024

@KaylorBen I am developing a vencord plugin as I mentioned, I am dealing alot with dynamic imports and bundlers, so I see fit to include the abbility for userplugins to specify their own derivation, which is optional, also I would like to address this in the same PR as git uri support and userplugin derivation are already quite intertwined in my PR. What do you think of this?

At the very least, a setting to enable this abbility for userplugin derviations.
Also the code isnt quite ready for review, its probably missing some documentation and cleaning up.

SpiderUnderUrBed added a commit to SpiderUnderUrBed/nixcord that referenced this pull request Oct 30, 2024
@KaylorBen
Copy link
Owner

Testing this now, thanks for putting a lot of work into it, and sorry I haven't looked that deep into it. Should be fine to merge if it doesn't cause any issues.

@SpiderUnderUrBed
Copy link
Author

SpiderUnderUrBed commented Nov 29, 2024

The git branch is polluted, I had issues with local testing so I had to push all my changes to a testing branch, I don't know why it is merging the wrong histories (or appearing so).

Aside from that, I made it more modular, I added the git uri and path functionality, and the ability for userplugins to specify their own derivation, and I understand most of the code which had no documentation.

I plan to:
-Remove all remnants of testing, which includes my traces
-add documentation to undocumented areas
-add documentation to my code
-Ensure the correct history will be merged

Some of these changes arnt things I done which confuses me, like hash changes.
Excuse me if I said something dumb, I don't do many PRs.

After a bit of more work then it'll be OK to merge.

@KaylorBen
Copy link
Owner

I pulled it and it builds my config correctly w/t custom plugins and such, so just a matter of removing testing stuff and traces and it should be good I think.

DontEatOreo and others added 29 commits December 7, 2024 17:34
Add an option to specify a custom Vencord package while maintaining
the default patched version. This allows users to "bring their own"
Vencord package

Apply `applyPostPatch` to any selected Vencord package (our default
or user-provided one). This func is needed for installing plugins from
`userPlugins`
…ut error, note: will need to clean up comments after testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants