-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local git uri support for userPlugins and the abbility for userPlugins to specify their own derivation #40
base: main
Are you sure you want to change the base?
Conversation
fixes #39 |
I am having issues with the plugin being properly imported, maybe this is specific to the local git uri, further testing is needed. |
Sorry I've been busy for the past few days, Ill be able to look this over and maybe write some code for it in a couple days from now |
The original code for the plugins was taken from a user flake I found, so I don't fully understand how it works |
@KaylorBen I am developing a vencord plugin as I mentioned, I am dealing alot with dynamic imports and bundlers, so I see fit to include the abbility for userplugins to specify their own derivation, which is optional, also I would like to address this in the same PR as git uri support and userplugin derivation are already quite intertwined in my PR. What do you think of this? At the very least, a setting to enable this abbility for userplugin derviations. |
Testing this now, thanks for putting a lot of work into it, and sorry I haven't looked that deep into it. Should be fine to merge if it doesn't cause any issues. |
The git branch is polluted, I had issues with local testing so I had to push all my changes to a testing branch, I don't know why it is merging the wrong histories (or appearing so). Aside from that, I made it more modular, I added the git uri and path functionality, and the ability for userplugins to specify their own derivation, and I understand most of the code which had no documentation. I plan to: Some of these changes arnt things I done which confuses me, like hash changes. After a bit of more work then it'll be OK to merge. |
I pulled it and it builds my config correctly w/t custom plugins and such, so just a matter of removing testing stuff and traces and it should be good I think. |
Add an option to specify a custom Vencord package while maintaining the default patched version. This allows users to "bring their own" Vencord package Apply `applyPostPatch` to any selected Vencord package (our default or user-provided one). This func is needed for installing plugins from `userPlugins`
…ut error, note: will need to clean up comments after testing
140e6ee
to
181cc46
Compare
This might not be fully finished, nor fully tested, I moved everything like regex to the top and separated github and git pattern matching, I removed coercion and instead did mapping later and used types.oneOf to choose from one of several pattern types such as package, path, git, GitHub.
TODO:
Right now I am not utilizing the rev I get from git, which I can use for version pinning.
I am open for suggestions on how to improve this.