Merge pull request #87 from KuceraMartin/pr/request-factory-from-globals

Nette\Http\RequestFactory BC break fixup
Kdyby · Jan 11, 2021 · c753f77 · c753f77
2 parents 533e695 + 35abe05
commit c753f77
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/HttpRequestFactory.php b/src/HttpRequestFactory.php
@@ -37,10 +37,10 @@ public function setFakeRequestUrl($url, ?string $scriptPath = NULL): void
 		}
 	}
 
-	public function createHttpRequest(): \Nette\Http\Request
+	public function fromGlobals(): \Nette\Http\Request
 	{
 		if ($this->fakeUrl === NULL || PHP_SAPI !== Application::CLI_SAPI || !empty($_SERVER['REMOTE_HOST'])) {
-			return parent::createHttpRequest();
+			return parent::fromGlobals();
 		}
 
 		return new HttpRequest($this->fakeUrl, NULL, [], [], [], PHP_SAPI, PHP_SAPI, '127.0.0.1', NULL);

diff --git a/tests/KdybyTests/Console/HttpRequestFactoryTest.phpt b/tests/KdybyTests/Console/HttpRequestFactoryTest.phpt
@@ -31,7 +31,7 @@ class HttpRequestFactoryTest extends \Tester\TestCase
 			'/path/'
 		);
 
-		$httpRequest = $requestFactory->createHttpRequest();
+		$httpRequest = $requestFactory->fromGlobals();
 		Assert::same(Application::CLI_SAPI, $httpRequest->getMethod());
 
 		$presenterFactory = new PresenterFactory();