Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application: fix Throwable handling #66

Closed
wants to merge 1 commit into from

Conversation

matej21
Copy link
Contributor

@matej21 matej21 commented Apr 7, 2017

it was probably broken by 2451e93

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 80.672% when pulling de07d3a on matej21:fix/throwable into 9dbfd06 on Kdyby:master.

@enumag
Copy link
Member

enumag commented Apr 7, 2017

I'm pretty sure I didn't break that - I only changed code inside the } catch (\Exception $e) { so I could't have changed the behavior for Throwable.

Anyway 👍

@matej21
Copy link
Contributor Author

matej21 commented Apr 7, 2017

@enumag I think other throwable errors were logged here 2451e93#diff-c893c788a9128ec350af949ac5724960L191

@enumag
Copy link
Member

enumag commented Apr 7, 2017

Oh. Yeah that could have affected it. Nice catch. :-)

@fprochazka
Copy link
Member

Thank you guys!

fprochazka pushed a commit that referenced this pull request May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants