Upgrade nette #79
Merged
Upgrade nette #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unified travis.yml - Added PHPStan to travis - Added CodingStandard to travis - removed unused nette libraries - Added PHPStan - Added Kdyby/CodingStandard - Moved PHPCoveralls to composer - Added Typo3/ClassAliasLoader
- Old namespaces aliased
…ation - application requires all packages which is adding too much dependecies to library
`onShutdown` only magically calls foreach on property, so i did it here too.
- so use them as if it was application - added to properties and made getters
Spamercz
force-pushed
the
upgrade-nette
branch
2 times, most recently
from
1da2c68
to
0d336f8
Compare
- Resolved set of working dependencies, not much space to navigate because of typed interfaces in nette 3.0 - Temporary added forked kdyby/events - Updated CLIRouter to new nette/routing (implemented different interface, match returns array instead of \Nette\Application\Request - CLIPresenter needs name but nette now does not allow to modify
fprochazka
reviewed
Apr 8, 2019
fprochazka
reviewed
Apr 8, 2019
fprochazka
reviewed
Apr 9, 2019
| }, | ||
| "minimum-stability": "dev", |
There was a problem hiding this comment.
tohle by tady imho mělo zustat, ne?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer require PHP >= 7.1
Travis and Composer cleanup
Exception split to own files
Other
onShutdownonly magically calls foreach on property, so i did it here too.unused arguments in tests reported by PHPStan
TODO