Speed up get_json_pointer #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex only needs to get called when there's a double quote somewhere in the input. Benchmarks below are for the two cases: When there's no double quote, we skip the regex and go fast. When there is a double quote, we run the regex and go slow. test bench_get_json_pointer ... bench: 96 ns/iter (+/- 1) test bench_get_json_pointer_with_map ... bench: 518 ns/iter (+/- 18)
Keats
approved these changes
Oct 13, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex only needs to get called when there's a double quote somewhere
in the input.
Benchmarks below are for the two cases: When there's no double quote, we
skip the regex and go fast. When there is a double quote, we run the
regex and go slow.
test bench_get_json_pointer ... bench: 96 ns/iter (+/- 1)
test bench_get_json_pointer_with_map ... bench: 518 ns/iter (+/- 18)
The regex calls showed up in profiling of rustdoc.