-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rector] Apply Doctrine ORM 2.9 SetList #104
[Rector] Apply Doctrine ORM 2.9 SetList #104
Conversation
samsonasik
commented
Aug 26, 2021
•
edited
Loading
edited
- update latest rector 0.11.51
- menerapkan Doctrine ORM 2.9 Rector SetList untuk migrasi dari annotation ke attribute
- menerapkan symfony 5.2 set
- re-run rector.
mas @samsonasik bisa ga sekalian router-nya juga pakai attributes? |
Ok mas, sudah diterapkan dengan symfony-5.2 set 3ebe170 👍 |
3ebe170
to
4efaef2
Compare
rebased, re-run rector. |
Mantap mas @samsonasik, cuma kok blank line code-nya juga ikutan ilang mas... Padahal itu untuk memudahkan dalam membaca codenya... Kayaknya terlalu strict mas rules-nya |
$audit = $this->audit->getAudits($entity, $id)->toArray(); | ||
$class = new ReflectionClass(ApiClient::class); | ||
$context = StringUtil::lowercase($class->getShortName()); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blank line seharusnya ga ilang mas @samsonasik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iya, kelemahan Ast disitu https://github.com/rectorphp/rector#known-drawbacks . Harus pakai coding standard tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iya udah dibahas di sini juga (ada yang complain juga... Bagusnya bagaimana ya mas? Kalau harus ngerapiin satu2 agak sulit juga mas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saya coba run php-cs-fixer dengan @Symfony
rules 7a9e757
php-cs-fixer fix lib --rules=@Symfony
Hasilnya: 7a9e757
Kalau ada cs-fixer lain boleh mas dicoba, atau bisa juga pakai easy-coding-standard https://github.com/symplify/easy-coding-standard
4efaef2
to
fea452b
Compare
mas @samsonasik setidaknya return-nya ga gabung, untuk yang lain bisa sambil jalan nanti dirapikan... |
Maaf mas @samsonasik saya revert karena ternyata bundle extension doctrine belum support attribute |
ok mas 👍 |