Refactor CIPP Settings #2208
Merged
Refactor CIPP Settings #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
k-grube
commented
Mar 12, 2024
k-grube
commented
- New component, CippCallout which is dismissible version of CCallout
- Replaced inconsistent usage of CAlert and CCallout with CippCallout
- Refactor shared Lazy loading into component CippLazy
- Refactor CIPPSettings.jsx into components per tab and sections as needed.
- Fix issue with setting password config
- Bump package version to match release version
- Bump font awesome package to latest (for the X icon on CippCallout)
…h combines CCallout and CAlert but is dismissible. Fix issues with notification not appearing when running a second time. Fix issue with password config not working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.